Skip to content

Fix "allow preview" for published filter setting. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2020
Merged

Fix "allow preview" for published filter setting. #22

merged 2 commits into from
Mar 29, 2020

Conversation

@richardhj
Copy link
Member

@richardhj richardhj commented Mar 20, 2020 •
edited by zonky2
Loading

Description

"allow preview" for published filter did not work properly.

Checklist

  • Read and understood the CONTRIBUTING guidelines
  • Created tests, if possible
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself to the @authors in touched PHP files
  • Checked the changes with phpcq and introduced no new issues

@zonky2 zonky2 modified the milestones: 2.1.0, 2.1.1 Mar 27, 2020
@zonky2 zonky2 requested a review from stefanheimes March 27, 2020 15:38
@zonky2
Copy link
Contributor

zonky2 commented Mar 27, 2020

@richardhj pls check tests...

@richardhj richardhj added bug and removed enhancement labels Mar 27, 2020
@zonky2
Copy link
Contributor

zonky2 commented Mar 27, 2020

@richardhj hast Du das auch mal getestet?

@stefanheimes stefanheimes merged commit 38ef200 into hotfix/2.1.1 Mar 29, 2020
@stefanheimes stefanheimes deleted the hotfix/allow-preview branch March 29, 2020 16:45
@zonky2
Copy link
Contributor

zonky2 commented Mar 30, 2020

@richardhj
Error at C4.4

                                                                               
  An error occurred while executing the "contao:install-web-dir" command:      
  In CheckExceptionOnInvalidReferenceBehaviorPass.php line 31:                 
                                                                               
                                                                               
    The service "metamodels.attribute_checkbox.published_filtersetting.factor  
  y"                                                                           
     has a dependency on a non-existent service "contao.security.token_checke  
  r"                                                                           
    .

see https://community.contao.org/de/showthread.php?77583-Fehler-beim-Update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanheimes stefanheimes Awaiting requested review from stefanheimes

Assignees

@richardhj richardhj

Labels

bug

Projects

None yet

Milestone

2.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@richardhj @zonky2 @stefanheimes